For NBA, Star and older is vintage. That's 1985-86 and older. While that's not that long ago, the way that part of the hobby worked was different before then, it's a clean, clear break where things changed.
NASCAR has no true vintage releases, but the argument could be made for any of the promos and oddballs issued before 1988 Maxx. For other forms of racing I would say anything before the A&S Indy sets.
I have not learned for hockey, yet.
For non-sports there is not as clear a demarcation as there is in the NBA. I tend to go with the somewhat arbitrary if it's older than me it's vintage take, but that works as well because I was born in 1984, which makes the Return of the Jedi set the last vintage issue.
I suspect, in several decades, probably after the lifespan of everyone reading this, that eventually the vintage/modern break will be 1990/91. The change from brown or textured backs to glossy white cardstock affected every single sport and non-sports at the same time, pretty much. While that is still something we remember happening, there will come a time when that's not in the collective memory of the majority of collectors. Then, and only then, will that likely be the prevailing way of thought, and I don't think any of us will see it. Maybe Ian as he's a bit younger than the rest of us, but honestly I don't expect that to happen in the next hudred years.
VERY slow trading due to health problems. Not transferrable so safe to trade with, just moving is painful and can't always access the cards.
Cardboard History My COMC
New Collection Website: Cardboard History Gallery (Still under construction)
Tips on how to make your scans look like the card does in hand (No more washed out, fuzzy scans!):